Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(thanos): unhide configuration docs for thanos storage clients (backport k239) #16142

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Feb 7, 2025

Backport 1cd95f5 from #16051


What this PR does / why we need it:

Unhides docs for configuring thanos storage clients. This will be made available in the next minor release.

Special notes for your reviewer:
I made a minor change to the docs generator to not expand inline root blocks to avoid repetition. We can make this configurable by a doc tag doc:"noexpand" if we want to control this behavior

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner February 7, 2025 06:44
@loki-gh-app loki-gh-app bot added backport size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Feb 7, 2025
@loki-gh-app loki-gh-app bot requested a review from ashwanthgoli February 7, 2025 06:44
Copy link
Contributor

github-actions bot commented Feb 7, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 0ab9121 into k239 Feb 10, 2025
67 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-16051-to-k239 branch February 10, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant