Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataobj): Use kgo Balancer for dataobj-consumer #16146

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Feb 7, 2025

What this PR does / why we need it:

  • Switches to the existing CooperativeSticky load balancing strategy for multi-tenant streams. The custom strategy is no longer required because we don't have to account for active/inactive partitions.
  • Also used a buffer pool for flushing, which avoids needing to permanently allocate a large buffer that we only use once every few minutes
    • The pool is shared between all producers which reduces total memory usage but may still spike if many objects need to be flushed at once. We could probably improve this via some coordination / flush workers but thats for another day.

@benclive benclive requested a review from a team as a code owner February 7, 2025 14:42
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 7, 2025
@benclive benclive merged commit 52cb0af into main Feb 7, 2025
59 checks passed
@benclive benclive deleted the remove-custom-rebalancing-strat branch February 7, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants