Change function name to containsVolume

Signed-off-by: Ruben Vargas <[email protected]>

internal/manifests/manifestutils/tls.go

@@ -28,8 +28,8 @@ func MountCAConfigMap(
 		ReadOnly:  true,
 	})
 
-	volumeIndex, _ := findVolumeIndex(pod, caConfigMap)
-	if volumeIndex < 0 {
+	hasVolume := containsVolume(pod, caConfigMap)
+	if !hasVolume {
 		pod.Volumes = append(pod.Volumes, corev1.Volume{
 			Name: caConfigMap,
 			VolumeSource: corev1.VolumeSource{
@@ -63,8 +63,8 @@ func MountCertSecret(
 		ReadOnly:  true,
 	})
 
-	volumeIndex, _ := findVolumeIndex(pod, certSecret)
-	if volumeIndex < 0 {
+	hasVolume := containsVolume(pod, certSecret)
+	if !hasVolume {
 		pod.Volumes = append(pod.Volumes, corev1.Volume{
 			Name: certSecret,
 			VolumeSource: corev1.VolumeSource{
@@ -126,12 +126,12 @@ func findContainerIndex(pod *corev1.PodSpec, containerName string) (int, error)
 	return -1, fmt.Errorf("cannot find container %s", containerName)
 }
 
-func findVolumeIndex(pod *corev1.PodSpec, volumeName string) (int, error) {
-	for i, volume := range pod.Volumes {
+func containsVolume(pod *corev1.PodSpec, volumeName string) bool {
+	for _, volume := range pod.Volumes {
 		if volume.Name == volumeName {
-			return i, nil
+			return true
 		}
 	}
 
-	return -1, fmt.Errorf("cannot find volume %s", volumeName)
+	return false
 }