Allow otlp grpc and http to be enabled with TLS on monolithic #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
changed the title
rubenvp8510
force-pushed
the
fix_tls_monolithic_both_enabled
branch
2 times, most recently
from
ec7b1cb to
990f535
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
=======================================
Coverage 73.22% 73.23%
=======================================
Files 105 105
Lines 6503 6512 +9
=======================================
+ Hits 4762 4769 +7
- Misses 1450 1451 +1
- Partials 291 292 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rubenvp8510
force-pushed
the
fix_tls_monolithic_both_enabled
branch
4 times, most recently
from
8b3b70b to
7bb9fd5
Compare
rubenvp8510
force-pushed
the
fix_tls_monolithic_both_enabled
branch
from
7bb9fd5 to
33abac3
Compare
pavolloffay
reviewed
Jul 11, 2024
rubenvp8510
force-pushed
the
fix_tls_monolithic_both_enabled
branch
from
c6b1049 to
95eb3c1
Compare
iblancasa
approved these changes
Jul 11, 2024
Comment on lines
31
to
32
| hasVolume := containsVolume(pod, caConfigMap) | ||
| if !hasVolume { |
There was a problem hiding this comment.
How about?
Suggested change
| hasVolume := containsVolume(pod, caConfigMap) | |
| if !hasVolume { | |
| if !containsVolume(pod, caConfigMap) { |
There was a problem hiding this comment.
it's fine. I can do the change
There was a problem hiding this comment.
Changed! thanks for the review!
| // ReceiverHTTPTLSCADir is the path that is mounted from the configmap for TLS for receiver. | ||
| ReceiverHTTPTLSCADir = "/var/run/ca-receiver/http" | ||
| // ReceiverHTTPTLSCertDir returns the mount path of the receivers certificates (for ingesting traces). | ||
| ReceiverHTTPTLSCertDir = TLSDir + "/receiver/http" |
There was a problem hiding this comment.
Wht don't we use path.Join here?
There was a problem hiding this comment.
We can but I don't think we need it, this are constants, we don't need to deal with double slashes, empty strings etc..
rubenvp8510
force-pushed
the
fix_tls_monolithic_both_enabled
branch
from
95eb3c1 to
0e4a8c4
Compare
Signed-off-by: Ruben Vargas <[email protected]>
pavolloffay
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #976