Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tweaks with sync-ing to latest version from main [GRF-6059] #4

Merged

Conversation

bcalvert-graft
Copy link

Description

I bumped graft/sematic/main to the latest version (0.41) from the main Sematic repo. It was too hard/messy to figure out how to do that in a PR, so I just pushed that commit (Graft installs from that branch with a specific commit SHA so this kind of forced pushing should be fine if done sparingly).

With that bump in place, this PR does a few more tweaks on top. Listing them out

  1. The Sematic devs have moved off of Bazel for internal library development (see PR 1145 to the main repo). I think this means we don't need to specify poetry as part of the build-system
  2. I've added the boltons dependency so I can remove some vendored code
  3. I ran make fix with their new ruff-based linting (added in PR 1138 to the main repo)

Follow-up work

Point Graft to this forked version

Copy link

@mick-graft mick-graft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcalvert-graft bcalvert-graft merged commit dd956a8 into graft/sematic/main Jan 13, 2025
8 checks passed
@bcalvert-graft bcalvert-graft deleted the bcal/sematic_fork/upgrade_to_v0p41 branch January 13, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants