Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-Butt Joint #381

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Y-Butt Joint #381

wants to merge 6 commits into from

Conversation

obucklin
Copy link
Contributor

@obucklin obucklin commented Jan 29, 2025

Say hello to the much anticipated Y-Butt Joint! This is the first iteration of a Y-Topology Joint, and is currently generated using a JointsRulesFromList Component/ DirectRule. It requires the updates from DoubleCut rework #376. This maintains the lap functionality including mill pockets.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@obucklin
Copy link
Contributor Author

image
image
image
image

Base automatically changed from DoubleCut_rework to main January 30, 2025 14:04
@obucklin obucklin linked an issue Jan 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YButtJoint
1 participant