FreeContour BTLxProcessing
#382
Open
+449
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Feb 6, 2025
There was a problem hiding this comment.
left some comments.
if @papachap can have a look it would be great
| # create subprocessing elements | ||
| if self.subprocessings: | ||
| for subprocessing in self.subprocessings: | ||
| processing_element.append(self._create_processing(subprocessing)) |
There was a problem hiding this comment.
as BTLxWriter_create_processing() gets removed, recursively call create_processing here.
There was a problem hiding this comment.
@papachap can you confirm that this works as currently written? is there a processing we could test this on?
|
I responded to @chenkasirer s comments. Will wait for @papachap :-) |
added test, removed writer._create_part
papachap
reviewed
Feb 10, 2025
| @@ -155,8 +155,8 @@ def _create_project_element(self, model): | |||
| # create parts element | |||
| parts_element = ET.SubElement(project_element, "Parts") | |||
| # create part elements for each beam | |||
| for i, beam in enumerate(model.beams): # TODO: we need to add at least Plates to this too. | |||
| part_element = self._create_part(beam, i) | |||
| for i, element in enumerate(list(model.beams) + list(model.plates)): | |||
There was a problem hiding this comment.
maybe update the _create_part() method as well to accept an element instead of a beam and adjust the docstring.
papachap
reviewed
Feb 10, 2025
| processings : list | ||
| A list of the processings applied to the beam. | ||
| et_element : :class:`~xml.etree.ElementTree.Element` | ||
| The ET element of the BTLx part. | ||
|
|
||
| """ | ||
|
|
||
| def __init__(self, beam, order_num): | ||
| self.beam = beam | ||
| def __init__(self, element, order_num): |
There was a problem hiding this comment.
Please update the docstring accordingly.
papachap
reviewed
Feb 10, 2025
| ) | ||
| # create parameter subelements | ||
| for key, value in self.params_dict.items(): | ||
| print(key, value) |
papachap
reviewed
Feb 10, 2025
| @@ -177,7 +193,7 @@ def compute_aabb(self, inflate=0.0): | |||
| box.zsize += inflate | |||
| return box | |||
|
|
|||
| def compute_obb(self, inflate=0.0): | |||
| def compute_obb(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
FreeContourBTLx Processing and updates thePlateelement to function as a BTLx Part. ThePlate.geometryis now created withFreeContour(and other) processings. TheSurfaceModelandSurfaecModel.Windowhave been updated to generateFreeContourfeatures and output BTLx files with all elements.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.