Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 22.04 for CI #1859

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

DavidMStraub
Copy link
Member

In #1858, I realized the CI currently runs on Ubuntu 20.04, which uses Python 3.8, that we are not supporting anymore. This PR switches conservatively to 22.04 LTS, which uses Python 3.10. One package had to be removed as well to make it run, but I believe this is anyway an old Python 2 leftover.

@Nick-Hall
Copy link
Member

Thew new package name for python-libxml2 is python3-libxml2.

Copy link
Member

@dsblank dsblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nick-Hall
Copy link
Member

56 unit tests are being skipped.

@DavidMStraub
Copy link
Member Author

56 unit tests are being skipped.

But they are currently skipped everywhere, also on master.

Thew new package name for python-libxml2 is python3-libxml2.

Thanks, added back.

@Nick-Hall
Copy link
Member

The tests that are skipped are from gramps.gen.merge.test.merge_ref_test and the message is:

skipped 'These tests need the 3rd-party plugins "CliMerge" and "ExportRaw".'

The gramps60 branch is not yet available for the addons, so this is understandable.

These are also the tests that require the lxml functionality.

@DavidMStraub
Copy link
Member Author

DavidMStraub commented Jan 20, 2025

I'm confused, nothing added in this PR changes the number of tests skipped compared to master, right?

@stevenyoungs
Copy link
Contributor

A change in OS configuration?
The tests appear conditional on

HAS_CLIMERGE = os.path.isdir(os.path.join(USER_PLUGINS, "CliMerge"))
HAS_EXPORTRAW = os.path.isdir(os.path.join(USER_PLUGINS, "ExportRaw"))

@Nick-Hall
Copy link
Member

We are trying to load the v5.2 version of CliMerge and ExportRaw which is going to fail. The tests are then skipped.

Everything is working in the gramps52 branch. I checked the unit tests as part of the v5.2.4 release process.

@Nick-Hall
Copy link
Member

Rebased.

@Nick-Hall Nick-Hall merged commit f5c002f into gramps-project:master Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants