Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct variable in baseselector to prevent error #1872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenyoungs
Copy link
Contributor

PR #1836 introduced a bug when selecting a single object.
This PR fixes it.

To reproduce:

  1. using a db with at least one person
  2. Shift+Alt+F to add a new family
  3. Click the select child button
  4. Select a child and click OK

An error similar to the following is generated

18794: ERROR: grampsapp.py: line 188: Unhandled exception
Traceback (most recent call last):
  File "C:\msys64\home\steve\gramps\gramps\gui\editors\editfamily.py", line 303, in share_button_clicked
    person = sel.run()
             ^^^^^^^^^
  File "C:\msys64\home\steve\gramps\gramps\gui\selectors\baseselector.py", line 248, in run
    result = self.get_from_handle_func()(id_list[0])
                                         ^^^^^^^
NameError: name 'id_list' is not defined

@Nick-Hall Nick-Hall added the bug label Jan 25, 2025
@stevenyoungs stevenyoungs changed the title Bug: Use the correct variable in baseselector to prevent error Use the correct variable in baseselector to prevent error Jan 25, 2025
@Nick-Hall Nick-Hall added this to the v6.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants