Safe mode working with Gramps 5.2 on Windows #1881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #0013300 Safe mode which was broken with Gramps 5.2.0-5.2.4 on Windows, has been fixed with commit. Previously code was looking for user configuration in APPDATA, but with the move to XDG-based directory layout (bug 8025), this was no longer correct. Per Nick Hall's review comment: Use the old directory structure if new structure is not present *and* the old location isn't empty (i.e. upgrade from pre-5.2 Gramps scenario). Otherwise, use the new XDG-based directory layout (new install of Gramps 5.2+ scenario).
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13300
Safe mode which was broken with Gramps 5.2.0-5.2.4 on Windows, has been fixed with commit.
Previously code was looking for user configuration in APPDATA, but with the move to XDG-based directory layout (bug 8025), this was no longer correct.
Per Nick Hall's review comment: Use the old directory structure if new structure is not present and the old location isn't empty (i.e. upgrade scenario from pre-5.2 Gramps), otherwise, use the new XDG-based directory layout (i.e. new install scenario of Gramps 5.2+).
TESTING
Test to verify that safe mode functions as described, i.e. starting from a user's customized environment, verify that existing family trees are available in safe mode but settings and configuration are not.
NOTE: This also fixes #13261 which documents another way in which this bug manifests. However, this is bug is closer to the root cause and easier to test.
For previous discussion of this change, see PR #1726