Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to conda #369

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

Blanderbuss
Copy link

To install all:
conda install -c pygraphistry_dev graphistry-dev
To install one package:
conda install -c pygraphistry_dev graphistry_dev.graphistry_core
Right now action is only run manually.
Currently configured for the dev anaconda account

with:
subDir: 'conda'
AnacondaToken: ${{ secrets.ANACONDA_TOKEN }}
platforms: 'linux'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a prepublish test we can do? Ex: In pip, we do a test publish to test.pypi.org first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After researching, I don't belive that there is a way to perform a test publish for conda

conda/meta.yaml Outdated
@@ -0,0 +1,65 @@
package:
name: graphistry-dev
version: "0.25.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version seems hard-coded here, while it should be taken from the git tag -- am I misreading somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it, for some reason this env variable is not present

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by switching to different github action

conda/meta.yaml Outdated
- name: graphistry_dev.graphistry-umap
requirements:
- umap-learn
- dirty_cat
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See setup.py for min dirty_cat version req + add scikit-learn (with min version)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

conda/meta.yaml Outdated
- dirty_cat
- name: graphistry_dev.graphistry-ai
requirements:
- scikit-learn
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see setup.py for min version reqs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


outputs:
- name: graphistry_dev.graphistry_core
requirements:
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything like outputs.*.description where they can point to the main conda package for instructions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put instructions in the main description and it will be used for all outputs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check here to see how the description looks like right now

conda/meta.yaml Outdated

about:
home: https://www.graphistry.com/
license: BSD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSD3 + license file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

conda/meta.yaml Outdated
about:
home: https://www.graphistry.com/
license: BSD
summary: Visual Graph Analytics library for Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphistry Visual Graph ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

conda/meta.yaml Outdated
description: |
Graphistry is a visual graph analytics library for extracting, transforming,
displaying, and sharing big graphs with end-to-end GPU acceleration
doc_url: https://www.graphistry.com/docs
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

conda/meta.yaml Outdated
@@ -0,0 +1,65 @@
package:
name: graphistry-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing as part of landing, change to graphistry ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! See per-line reviews:

  • Parameterize version by git tag (we use X.Y.Z, in case conda needs a prefix)
  • Update dependencies, esp. min versions
  • Various individual settings changes

And some questions:

  • How should pre-publishing testing work?
  • Can we put instructions somewhere to guide users on different ways to install?

@Blanderbuss
Copy link
Author

@lmeyerov Answering you question about testing:

  • Conda runs tests after the build if there is a run_test.[py,pl,sh,bat] file in the recipe. If you want to test it without publishing locally, you can use --no-anaconda-upload option.

Other issues have been resolved as well as the possible answer to instruction, you can check them.

conda/meta.yaml Outdated Show resolved Hide resolved
@lmeyerov lmeyerov self-requested a review July 18, 2022 22:30
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - will try on prod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants