-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing to conda #369
base: master
Are you sure you want to change the base?
Publishing to conda #369
Conversation
.github/workflows/publish-conda.yml
Outdated
with: | ||
subDir: 'conda' | ||
AnacondaToken: ${{ secrets.ANACONDA_TOKEN }} | ||
platforms: 'linux' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a prepublish test we can do? Ex: In pip, we do a test publish to test.pypi.org
first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After researching, I don't belive that there is a way to perform a test publish for conda
conda/meta.yaml
Outdated
@@ -0,0 +1,65 @@ | |||
package: | |||
name: graphistry-dev | |||
version: "0.25.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version seems hard-coded here, while it should be taken from the git tag -- am I misreading somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on it, for some reason this env variable is not present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved by switching to different github action
conda/meta.yaml
Outdated
- name: graphistry_dev.graphistry-umap | ||
requirements: | ||
- umap-learn | ||
- dirty_cat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See setup.py
for min dirty_cat
version req + add scikit-learn
(with min version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
conda/meta.yaml
Outdated
- dirty_cat | ||
- name: graphistry_dev.graphistry-ai | ||
requirements: | ||
- scikit-learn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see setup.py
for min version reqs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
outputs: | ||
- name: graphistry_dev.graphistry_core | ||
requirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything like outputs.*.description
where they can point to the main conda package for instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put instructions in the main description and it will be used for all outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check here to see how the description looks like right now
conda/meta.yaml
Outdated
|
||
about: | ||
home: https://www.graphistry.com/ | ||
license: BSD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BSD3 + license file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
conda/meta.yaml
Outdated
about: | ||
home: https://www.graphistry.com/ | ||
license: BSD | ||
summary: Visual Graph Analytics library for Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graphistry Visual Graph ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
conda/meta.yaml
Outdated
description: | | ||
Graphistry is a visual graph analytics library for extracting, transforming, | ||
displaying, and sharing big graphs with end-to-end GPU acceleration | ||
doc_url: https://www.graphistry.com/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
conda/meta.yaml
Outdated
@@ -0,0 +1,65 @@ | |||
package: | |||
name: graphistry-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing as part of landing, change to graphistry
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! See per-line reviews:
- Parameterize version by git tag (we use
X.Y.Z
, in case conda needs a prefix) - Update dependencies, esp. min versions
- Various individual settings changes
And some questions:
- How should pre-publishing testing work?
- Can we put instructions somewhere to guide users on different ways to install?
@lmeyerov Answering you question about testing:
Other issues have been resolved as well as the possible answer to instruction, you can check them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - will try on prod!
To install all:
conda install -c pygraphistry_dev graphistry-dev
To install one package:
conda install -c pygraphistry_dev graphistry_dev.graphistry_core
Right now action is only run manually.
Currently configured for the dev anaconda account