polymorphic on expects a symbol
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymorphic belongs-to expects a symbol name as the "type" for a given subclass. In our case, we have had to customize Rails' polymorphic type derivation logic. So for any given AR model, we can't simply use the model's name in our polymorphic belongs-to.
To prevent duplicating (and decoupling) the knowledge of what a given model's polymorphic type name is, we're using:
```rb
polymorphic_belongs_to :approvable do
group_by(:approvable_type) do
on(Address.polymorphic_name) # is actually AddressList
```
However! This fails to match because the grouping logic is matching against `:AddressList` as a symbol.
We could of course .to_sym ourselves, but I think if graphiti intends to match against a symbol it should do the conversion itself to ensure the matching value is also a symbol.
|
@jasonkarns Mind adding a test for this? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
## [1.5.1](v1.5.0...v1.5.1) (2024-03-18) ### Bug Fixes * polymorphic `on` expects a symbol ([#433](#433)) ([4e58702](4e58702))
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
Fix polymorphic type mismatch in polymorphic_belongs_to by ensuring symbol conversion
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
## [1.5.1](graphiti-api/graphiti@v1.5.0...v1.5.1) (2024-03-18) ### Bug Fixes * polymorphic `on` expects a symbol ([graphiti-api#433](graphiti-api#433)) ([4e58702](graphiti-api@4e58702))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymorphic belongs-to expects a symbol name as the "type" for a given subclass. In our case, we have had to customize Rails' polymorphic type derivation logic. So for any given AR model, we can't simply use the model's name in our polymorphic belongs-to.
To prevent duplicating (and decoupling) the knowledge of what a given model's polymorphic type name is, we're using:
However! This fails to match because the grouping logic is matching against
:AddressListas a symbol.We could of course .to_sym ourselves, but I think if graphiti intends to match against a symbol it should do the conversion itself to ensure the matching value is also a symbol.