-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local file system and remote object storage #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
added
size:large
Large
p1
High priority
type:feature
New or enhanced functionality
labels
Mar 7, 2024
hopeyen
force-pushed
the
hope/remote-object-conn
branch
from
March 7, 2024 05:51
4e01038
to
038044b
Compare
hopeyen
force-pushed
the
hope/remote-object-conn
branch
2 times, most recently
from
March 7, 2024 20:12
8677a74
to
6043a83
Compare
hopeyen
force-pushed
the
hope/remote-object-conn
branch
from
March 7, 2024 20:14
6043a83
to
6adcb0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of
std::fs
, use [object_store
] (https://crates.io/crates/object_store) from Apache Arrow./tmp/bucket/...
is used to store the bytes during download for precise writing of the chunks, then uploaded to the bucket after complete downloadIssue link (if applicable)
Resolves #15
Checklist