Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunrise FAQ #541

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Sunrise FAQ #541

merged 7 commits into from
Oct 31, 2023

Conversation

MichaelMacaulay
Copy link
Contributor

No description provided.

@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner October 30, 2023 22:12
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 661.42 KB (🟡 +76 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/en/sunrise 9.06 KB 670.48 KB 191.57%


It is designed to improve the experience of upgrading subgraphs from the hosted service to The Graph Network and supporting new versions of existing subgraphs that have not yet been indexed.

The upgrade Indexer is aimed at bootstrapping chains that do not yet have indexing rewards on the network, as well as a fallback for new subgraph versions. The goal is to ensure that an Indexer is available to serve queries as quickly as possible after a subgraph is published.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says "an upgrade Indexer" while this says "The upgrade Indexer", so I find it a bit confusing... is there just one, or are there multiple upgrade Indexers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, there is only one initially but other Indexers are encouraged to become upgrade Indexers as well. We already have 2 or 3 folks interested, with more potentially joining. However, there is no hard commitment. Hence, the hesitation around this.

This language comes directly from a google doc that many people have reviewed, so I lean toward keeping the phrasing as is, and changing later if needed. Does that make sense?

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth adding:

  • An indication that we will continue to add to this FAQ as there is more information to share
  • Where to go if you have questions

website/pages/en/sunrise.mdx Outdated Show resolved Hide resolved
@MichaelMacaulay MichaelMacaulay merged commit 5b069fd into main Oct 31, 2023
3 checks passed
@MichaelMacaulay MichaelMacaulay deleted the sunrise-faq branch October 31, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants