Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new global header + misc. improvements and fixes #546

Merged
merged 22 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci-cd-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push Docker image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v4
with:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
cache-to: type=inline
build-args: |
ENVIRONMENT=production
tags: |
${{ env.BASE_IMAGE }}:${{ github.sha }}
${{ env.BASE_IMAGE }}:latest
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-cd-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@ jobs:
with:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
build-args: |
ENVIRONMENT=staging
saihaj marked this conversation as resolved.
Show resolved Hide resolved
push: false
2 changes: 2 additions & 0 deletions .github/workflows/ci-cd-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
context: . # required to respect .dockerignore
cache-from: type=registry,ref=${{ env.BASE_IMAGE }}:latest
cache-to: type=inline
build-args: |
ENVIRONMENT=staging
tags: |
${{ env.BASE_IMAGE }}:${{ github.sha }}
${{ env.BASE_IMAGE }}:latest
Expand Down
4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
FROM node:18-alpine as builder

ARG ENVIRONMENT
ENV ENVIRONMENT=$ENVIRONMENT

ENV PNPM_HOME="/usr/bin"

RUN apk add --no-cache git
Expand All @@ -13,7 +16,6 @@ COPY . .
RUN pnpm install --frozen-lockfile --ignore-scripts

RUN pnpm build
RUN pnpm export

## production environment
FROM nginx:1.16.0-alpine
Expand Down
16 changes: 7 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,34 @@
"check": "pnpm typecheck && pnpm lint && pnpm prettier:check",
"check:fix": "pnpm typecheck; pnpm lint:fix",
"dev": "turbo run dev --parallel",
"docker:build": "DOCKER_BUILDKIT=1 docker build . -t docs --no-cache",
"docker:build": "source .env.local && DOCKER_BUILDKIT=1 docker build . -t docs --no-cache --build-arg ENVIRONMENT=$ENVIRONMENT",
"docker:clean": "docker builder prune",
"docker:up": "docker run --rm -it -p 3000:80 -v \"$(pwd)/nginx.conf:/etc/nginx/nginx.conf\" docs",
"export": "pnpm --filter @graphprotocol/docs export",
"lint": "eslint . --cache --ignore-path .gitignore --max-warnings 0",
"lint:fix": "eslint . --cache --ignore-path .gitignore --fix; pnpm prettier",
"pre-commit": "lint-staged --concurrent false",
"pre-push": "pnpm build",
"prepare": "husky install && chmod +x .husky/*",
"prettier": "pnpm prettier:check --write",
"prettier:check": "prettier --cache --check .",
"start": "pnpm --filter @graphprotocol/docs start",
"test": "turbo run test",
"typecheck": "turbo run typecheck"
},
"devDependencies": {
"@edgeandnode/eslint-config": "^2.0.2",
"eslint": "^8.52.0",
"@edgeandnode/eslint-config": "^2.0.3",
"eslint": "^8.55.0",
"eslint-plugin-mdx": "^2.2.0",
"husky": "^8.0.3",
"lint-staged": "^15.0.2",
"prettier": "^3.0.3",
"lint-staged": "^15.2.0",
"prettier": "^3.1.1",
"prettier-plugin-pkg": "^0.18.0",
"remark-frontmatter": "^5.0.0",
"remark-lint-first-heading-level": "^3.1.2",
"remark-lint-heading-increment": "^3.1.2",
"remark-lint-no-heading-punctuation": "^3.1.2",
"remark-lint-restrict-elements": "workspace:*",
"turbo": "^1.10.16",
"typescript": "^5.2.2"
"turbo": "^1.11.2",
"typescript": "^5.3.3"
},
"lint-staged": {
"**/*.{js,jsx,ts,tsx,mjs,cjs}": "eslint --fix",
Expand Down
22 changes: 11 additions & 11 deletions packages/nextra-theme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"typecheck": "tsc --noEmit"
},
"peerDependencies": {
"@edgeandnode/gds": "^2.9.3",
"@edgeandnode/go": "^3.0.3",
"@edgeandnode/gds": "3.0.0-global-header-1701913779061-6ea902d",
"@edgeandnode/go": "4.0.0-global-header-1701913779061-6ea902d",
"@emotion/react": "^11.11",
"next": "^13",
"next-seo": "^6",
Expand All @@ -39,23 +39,23 @@
"@radix-ui/react-collapsible": "^1.0.3",
"@radix-ui/react-visually-hidden": "^1.0.3",
"lodash": "^4.17.21",
"react-intersection-observer": "^9.5.2",
"react-use": "^17.4.0"
"react-intersection-observer": "^9.5.3",
"react-use": "^17.4.2"
},
"devDependencies": {
"@edgeandnode/gds": "^2.12.9",
"@edgeandnode/go": "^3.4.2",
"@edgeandnode/gds": "3.0.0-global-header-1701913779061-6ea902d",
"@edgeandnode/go": "4.0.0-global-header-1701913779061-6ea902d",
"@emotion/react": "^11.11.1",
"@types/lodash": "^4.14.200",
"@types/react": "^18.2.34",
"@types/react-dom": "^18.2.14",
"next": "13.5.6",
"@types/lodash": "^4.14.202",
"@types/react": "^18.2.44",
"@types/react-dom": "^18.2.17",
"next": "^14.0.4",
"next-seo": "^6.4.0",
"nextra": "^2.13.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"theme-ui": "^0.16.1",
"tsup": "^7.2.0"
"tsup": "^7.3.0"
},
"sideEffects": false
}
2 changes: 1 addition & 1 deletion packages/nextra-theme/src/components/Image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export type ImageProps = Omit<ImgHTMLAttributes<HTMLImageElement>, 'children'>
export const Image = ({ src, ...props }: ImageProps) => {
// If the URL is internal, automatically prepend the base path
if (src?.startsWith('/')) {
src = `${process.env.BASE_PATH}${src}`
src = `${process.env.BASE_PATH ?? ''}${src}`
}

return <img src={src} alt="" {...props} />
Expand Down
2 changes: 0 additions & 2 deletions packages/nextra-theme/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ export default function NextraLayout({ children, pageOpts, pageProps }: NextraTh
<div
sx={{
display: ['none', null, null, 'block'],
mt: 'calc(-1 * var(--gds-header-height) * var(--gds-header-fixed))',
marginInlineStart: '-8px',
marginInlineEnd: '16px',
}}
Expand Down Expand Up @@ -219,7 +218,6 @@ export default function NextraLayout({ children, pageOpts, pageProps }: NextraTh
<div
sx={{
display: ['none', null, null, 'block'],
mt: 'calc(-1 * var(--gds-header-height) * var(--gds-header-fixed))',
marginInlineStart: '32px',
marginInlineEnd: '-8px',
}}
Expand Down
12 changes: 2 additions & 10 deletions packages/nextra-theme/src/layout/MDXLayoutNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,15 @@ const DesktopWrapper = ({ children }: PropsWithChildren<{}>) => {
sx={{
zIndex: 1,
position: 'sticky',
top: 0,
maxHeight: '100vh',
top: 'var(--gds-header-height-visible)',
maxHeight: 'calc(100vh - var(--gds-header-height-visible))',
paddingInlineEnd: Spacing['24px'],
pt: Spacing['32px'],
pb: Spacing['16px'],
overflowY: 'auto',
transform: 'translateY(calc(var(--gds-header-height-visible) * var(--gds-header-fixed)))',
transition: enableTransition ? buildTransition('TRANSFORM', '400ms') : undefined,
}}
>
{children}
<div
sx={{
height: 'var(--gds-header-height-visible)',
transition: enableTransition ? buildTransition('height', '400ms') : undefined,
}}
/>
</div>
)
}
Expand Down
12 changes: 2 additions & 10 deletions packages/nextra-theme/src/layout/MDXLayoutOutline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@ export const MDXLayoutOutline = () => {
sx={{
zIndex: 1,
position: 'sticky',
top: 0,
maxHeight: '100vh',
top: 'var(--gds-header-height-visible)',
maxHeight: 'calc(100vh - var(--gds-header-height-visible))',
px: Spacing['8px'],
py: Spacing['32px'],
overflowY: 'auto',
transform: 'translateY(calc(var(--gds-header-height-visible) * var(--gds-header-fixed)))',
transition: enableTransition ? buildTransition('TRANSFORM', '400ms') : undefined,
}}
>
<Flex.Row>
Expand Down Expand Up @@ -66,12 +64,6 @@ export const MDXLayoutOutline = () => {
</nav>
</>
) : null}
<div
sx={{
height: 'var(--gds-header-height-visible)',
transition: enableTransition ? buildTransition('height', '400ms') : undefined,
}}
/>
</div>
)
}
12 changes: 6 additions & 6 deletions packages/og-image/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@
"dependencies": {
"@resvg/resvg-wasm": "2.6.0",
"react": "18.2.0",
"satori": "0.10.9",
"satori": "0.10.11",
"yoga-wasm-web": "0.3.3"
},
"devDependencies": {
"@cloudflare/workers-types": "^4.20231025.0",
"@types/react": "^18.2.34",
"jest-image-snapshot": "^6.2.0",
"@cloudflare/workers-types": "^4.20231121.0",
"@types/react": "^18.2.44",
"jest-image-snapshot": "^6.4.0",
"tsx": "^4.6.2",
"typescript": "^5.2.2",
"typescript": "^5.3.3",
"vitest": "^0.34.6",
"wrangler": "^3.15.0"
"wrangler": "^3.20.0"
}
}
Loading
Loading