Improve IPFS client selection #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
reviewed
Jan 8, 2025
| server_address: server_address.parse()?, | ||
| reason: anyhow!("unknown server kind"), | ||
| }); | ||
| clients.push(use_first_valid_api(server_address, logger).await?); |
isum
force-pushed
the
ion/improve-ipfs-client-selection
branch
from
d06830b to
e681d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves IPFS client selection by sending concurrent requests to all supported IPFS APIs and selecting the first one that responds with the expected status code.
Also, logging of IPFS test request retries has been disabled to not make it look like something is not working correctly.