Subgraph Composition: Support multiple subgraph datasources #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
force-pushed
the
krishna/sgc-declared-calls
branch
from
56f041a to
460f33e
Compare
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources
branch
from
6dfd085 to
a426a32
Compare
incrypto32
changed the base branch from
krishna/sgc-declared-calls
to
zoran/subgraph-composition-rework-vid-wrap2
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources
branch
from
a426a32 to
c61b650
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
02ce854 to
62d1e2b
Compare
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources
branch
from
c61b650 to
8c2be00
Compare
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources
branch
from
5c14264 to
1ff44c6
Compare
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources
branch
from
1ff44c6 to
f43bf1b
Compare
incrypto32
changed the base branch from
zoran/subgraph-composition-rework-vid-wrap2
to
krishna/sgc-multiple-sg-sources-fix
mangas
reviewed
Jan 16, 2025
| } | ||
|
|
||
| pub fn entity_type(&self) -> &str { | ||
| self.entity.entity_type.as_str() | ||
| } | ||
| } | ||
|
|
||
| impl Ord for TriggerData { | ||
| fn cmp(&self, other: &Self) -> std::cmp::Ordering { | ||
| match self.source_idx.cmp(&other.source_idx) { |
There was a problem hiding this comment.
This is somewhat important, I think would be worth some comments/documentation about the decision and why it is working this way. Also probably a simple test to ensure this assumption is not broken going forward
|
LGTM, really nice that you got added an integration test with the aggregation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.