Subgraph Compositions: Validations #5770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
reviewed
Jan 14, 2025
| @@ -37,6 +37,33 @@ const GQL_SCHEMA: &str = r#" | |||
| type TestEntity @entity { id: ID! } | |||
| "#; | |||
| const GQL_SCHEMA_FULLTEXT: &str = include_str!("full-text.graphql"); | |||
| // const SOURCE_SUBGRAPH_MANIFEST: &str = include_str!("source.yaml"); | |||
There was a problem hiding this comment.
minor thing - remove the comment.
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
10 times, most recently
from
b6f7492 to
640e7d1
Compare
incrypto32
force-pushed
the
krishna/sgc-validation
branch
from
ee37a70 to
3944111
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
3 times, most recently
from
14671db to
640e7d1
Compare
zorancv
reviewed
Jan 23, 2025
| @@ -1091,54 +1090,6 @@ async fn parse_data_source_context() { | |||
| ); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
Taking a second look at this PR, why is this test removed?
There was a problem hiding this comment.
Two reasons:
- The test is redudant - Everything this test does is done by the integraiton test
- The test keeps failing because it requires an actual source subgraph.. and some refactoring of the code is required to actually deploy a dummy source subgraph just for the validation to work. But in reality in runner test we mock the triggers and push the triggers directly and no source subgraph is actually needed.
SO i felt its just better to remove this test since, everything this test does is already done by the integration test and the work required to just make the new valdiations work with runner tests is probably unneccessary considering 1.
There was a problem hiding this comment.
Nice! Thanks for the explanation!
incrypto32
force-pushed
the
krishna/sgc-validation
branch
2 times, most recently
from
ae35584 to
799a3e9
Compare
incrypto32
changed the base branch from
zoran/subgraph-composition-rework-vid-wrap2
to
krishna/sgc-multiple-sg-sources-fix
incrypto32
force-pushed
the
krishna/sgc-multiple-sg-sources-fix
branch
from
06edc2b to
f38680e
Compare
incrypto32
force-pushed
the
krishna/sgc-validation
branch
from
799a3e9 to
b98760f
Compare
incrypto32
force-pushed
the
krishna/sgc-validation
branch
from
b98760f to
04a8e95
Compare
mangas
reviewed
Jan 30, 2025
| .context("Failed to resolve source subgraph manifest") | ||
| .map(Arc::new) | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
mangas
reviewed
Jan 30, 2025
| )); | ||
| } | ||
|
|
||
| let pruning_enabled = match source_manifest.indexer_hints.as_ref() { |
There was a problem hiding this comment.
pruning can also be set outside of the manifest right? Is there are a way we check that too?
mangas
reviewed
Jan 30, 2025
| @@ -211,8 +215,62 @@ pub struct UnresolvedMapping { | |||
| } | |||
|
|
|||
| impl UnresolvedDataSource { | |||
| fn validate_mapping_entities<C: Blockchain>( | |||
There was a problem hiding this comment.
Could you add some tests for this as well?
mangas
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Approve to unblock. As discussed, there are a few considerations:
- Pruning can also be run through graphman so we should try and avoid running composition if a subgraph was pruned (while not having that hint on manifest)
- The manifest hints, are hints. Therefore, it could (maybe should?) be possible to deploy the source subgraph WITHOUT pruning even though it has an indexing hint that suggests it be used.
- As this is a corner case I think it would be ok to document the issues and get back to them once we have the bulk of the work merged and working for the general case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.