-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipe function for watcher.rs and replaced usage #459
Conversation
Pull Request Test Coverage Report for Build 11751976614Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the right direction, just suggesting a few things to simplify the usage.
Hi, I think it's ready now, have used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like from the 4 uses of it, 3 don't need it to be async.
I still think that we should keep it as a future tho. If you have a better solution to tackle this go for it.
Else it looks good to me, just some questions and suggestions of improvement (if the compiler lets you do them).
Really sorry to ask but I'd really appreciate your help with some of these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review
hi, changed all of them, if any changes required please tell me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks alot for the helps 🥹 |
Fixes #456