Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move graphql queries to own crate #487

Merged
merged 1 commit into from
Nov 13, 2024
Merged

refactor: move graphql queries to own crate #487

merged 1 commit into from
Nov 13, 2024

Conversation

gusinacio
Copy link
Member

No description provided.

@gusinacio gusinacio force-pushed the gustavo/tap-290-move-graphql-to-query-folder branch from a38439f to b36b665 Compare November 13, 2024 19:06
@gusinacio gusinacio force-pushed the gustavo/tap-290-move-graphql-to-query-folder branch from b36b665 to 9781cd0 Compare November 13, 2024 19:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11824085661

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 72.133%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/query/src/lib.rs 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
crates/common/src/tap/checks/deny_list_check.rs 1 98.23%
crates/common/src/subgraph_client/monitor.rs 1 97.88%
Totals Coverage Status
Change from base Build 11824047251: -0.01%
Covered Lines: 5591
Relevant Lines: 7751
💛 - Coveralls

anirudh2
anirudh2 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple move. Nothing seems weird here

@gusinacio gusinacio merged commit 304cc56 into main Nov 13, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-290-move-graphql-to-query-folder branch November 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudh2 anirudh2 anirudh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @anirudh2