Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to negotiate the WebSocket protocol #584

Closed
spacemeowx2 opened this issue Mar 24, 2020 · 2 comments · Fixed by #1191
Closed

Better way to negotiate the WebSocket protocol #584

spacemeowx2 opened this issue Mar 24, 2020 · 2 comments · Fixed by #1191
Assignees
@tyranron
Labels
bug Something isn't working k::api Related to API (application interface) k::integration Related to integration with third-party libraries or systems lib::warp Related to `warp` crate integration
Milestone
0.16.0

Comments

@spacemeowx2
Copy link
Contributor

seanmonstar/warp#496

In the warp_subscriptions example, the playground cannot connect to the server via WebSocket because the WebSocket implementation in wrap has a unconfigurable Sec-WebSocket-Protocol header. Currently we can do a workaround adding the header manually.
@spacemeowx2 spacemeowx2 added bug Something isn't working needs-triage labels Mar 24, 2020
@LegNeato LegNeato added blocked k::integration Related to integration with third-party libraries or systems and removed needs-triage bug Something isn't working labels Mar 25, 2020
@cloudsftp
Copy link

Is this till current?
The example seems to work w/o the workaround

@tyranron tyranron added bug Something isn't working lib::warp Related to `warp` crate integration k::api Related to API (application interface) and removed blocked labels Nov 24, 2023
@tyranron tyranron self-assigned this Nov 24, 2023
@tyranron tyranron added this to the 0.16.0 milestone Nov 24, 2023
@tyranron tyranron linked a pull request Nov 24, 2023 that will close this issue
Improve WebSocket integration #1191
Merged
@tyranron
Copy link
Member

Fixed by auto-negotiating Sec-WebSocket-Protocol in #1191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyranron tyranron

Labels
bug Something isn't working k::api Related to API (application interface) k::integration Related to integration with third-party libraries or systems lib::warp Related to `warp` crate integration
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Improve WebSocket integration graphql-rust/juniper
4 participants
@LegNeato @tyranron @spacemeowx2 @cloudsftp