Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WebSocket integration #1191

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Improve WebSocket integration #1191

merged 14 commits into from
Sep 21, 2023

Conversation

tyranron
Copy link
Member

Follows and extends #1158
Related to #1022, #1186

Synopsis

In #1158 was added graphql-transport-ws GraphQL over WebSocket Protocol integration. However, new juniper_graphql_transport_ws crate wasn't wired correctly into CI, and clear documentation "who is who" is missing, leading to issues like #1186

Solution

Fill up the gaps around documentation, tooling and examples regarding new crates.

Additionally

Provide out-of-the box resolvers for automatic negotiation of the used WebSocket protocol in integration crates.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::documentation Related to project documentation k::integration Related to integration with third-party libraries or systems github_actions Pull requests that update GitHub Actions code labels Sep 14, 2023
@tyranron tyranron added this to the 0.16.0 milestone Sep 14, 2023
@tyranron tyranron self-assigned this Sep 14, 2023
@LegNeato
Copy link
Member

Sorry, I meant to come back through and fix these but got busy!

@tyranron tyranron marked this pull request as ready for review September 21, 2023 14:47
@tyranron tyranron merged commit 9849736 into master Sep 21, 2023
177 checks passed
@tyranron tyranron deleted the improve-ws branch September 21, 2023 21:24
@tyranron tyranron mentioned this pull request Sep 21, 2023
Closed
@tyranron tyranron mentioned this pull request Oct 16, 2023
Merged
4 tasks
@tyranron tyranron mentioned this pull request Oct 24, 2023
Merged
@tyranron tyranron linked an issue Nov 24, 2023 that may be closed by this pull request
Better way to negotiate the WebSocket protocol #584
Closed
@tyranron tyranron mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix github_actions Pull requests that update GitHub Actions code k::documentation Related to project documentation k::integration Related to integration with third-party libraries or systems
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

Better way to negotiate the WebSocket protocol
2 participants
@tyranron @LegNeato