Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve LSP tests #3510

Merged
merged 3 commits into from
Jan 24, 2024
Merged

improve LSP tests #3510

merged 3 commits into from
Jan 24, 2024

Conversation

acao
Copy link
Member

@acao acao commented Jan 21, 2024

  • mockfs strategy
  • move parseDocument tests to their own file
  • config failure/lifecycle tests

current issue: inline requires in cosmiconfig seem to break fs-mock in weird ways. un-skipping the last test leads to a segfault

Copy link

changeset-bot bot commented Jan 21, 2024

⚠️ No Changeset found

Latest commit: e2179ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (98af530) 55.74% compared to head (e2179ab) 55.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   55.74%   55.67%   -0.08%     
==========================================
  Files         114      114              
  Lines        5312     5308       -4     
  Branches     1444     1441       -3     
==========================================
- Hits         2961     2955       -6     
- Misses       1923     1930       +7     
+ Partials      428      423       -5     
Files Coverage Δ
...aphql-language-service-server/src/parseDocument.ts 100.00% <100.00%> (+13.33%) ⬆️
...l-language-service/src/interface/getDiagnostics.ts 83.87% <ø> (ø)
...hql-language-service-server/src/findGraphQLTags.ts 84.81% <0.00%> (+2.09%) ⬆️
...ql-language-service-server/src/MessageProcessor.ts 45.58% <33.33%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

acao added 3 commits January 24, 2024 20:58
- mockfs strategy
- move parseDocument tests to their own file
- config failure/lifecycle tests
@acao acao marked this pull request as ready for review January 24, 2024 20:01
@acao acao merged commit 253d76f into main Jan 24, 2024
14 checks passed
@acao acao deleted the lsp-tests branch January 24, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant