v1.1.1 #174
Merged
v1.1.1 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- docker python install changes. pin watchdog version, turn off unneeded caching. - docker entrypoint changes. run cite process immediately, ensure no simultaneous runs. - first time setup fixes. don't parse config.yaml as yaml, instead customize with string replacement to preserve key order and comments. - add title and link fallbacks to citation component - fix start/end markers for blog post excerpts, and remove special characters from hidden search attribute - change member page from col layout to float - add multi-line option to regex_scan liquid plugin (to support start/end marker bug above) - code, portrait, post excerpt css - fix testbed image links
- fix card component css
- fix versioning workflow to correctly parse and split changelog
- (re)include user pr template
✅ Deploy Preview for lab-website-template ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was
linked to
issues
Mar 24, 2023
|
d33bs
reviewed
Apr 6, 2023
|
Thanks for the review @d33bs , please take a look at my notes and recent commits. |
falquaddoomi
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Seems like @d33bs has done a pretty thorough review already. I made one comment, but otherwise it looks good to me.
falquaddoomi
approved these changes
Apr 6, 2023
d33bs
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog for high level, user-facing changes.