Skip to content

Commit

Permalink
fix(validation): check access when save system configurations form
Browse files Browse the repository at this point in the history
see #40
  • Loading branch information
hunghbmGG committed Nov 16, 2020
1 parent 799db88 commit 0988334
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/Http/Controllers/ConfigController.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,16 @@ public function update(Request $request)
$configs = config('config.system');
$rules = $booleans = $types = [];

// Get user role, exp for developer: admin
$userRole = 'admin';

// Get validation from config file
foreach ($configs as $config) {
if ($config['key'] == 'configuration.system.fields') {
foreach ($config['fields'] as $field) {
if (! isset($field['access']) || ! in_array($userRole, $field['access']))
continue;

if (isset($field['validation']))
$rules[$field['code']] = $field['validation'];

Expand Down
12 changes: 12 additions & 0 deletions src/Http/Controllers/laravel-config-firebase.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"type": "service_account",
"project_id": "laravel-config",
"private_key_id": "a22e2710931b714e016885c0de0c0dcab77607ae",
"private_key": "-----BEGIN PRIVATE KEY-----\nMIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQCuSFmJq5zamO26\n/HZbGyjFavlThmX8wRkHOI7RusTdFzg2y48pNmkJ/vXk0O2r3j2JcTghBNv/0TLP\n/PdeY8PrxcTG1xPeAmLkpY/W+n3VALvFdzidNbxLDZ1g48QwvUaAxVI5F1r+LWbC\nqJjLOEZxPCi0zpoEhmpuAJaqXodIN9b4frVH5V9DRja2Pj1P3UypgtbYjYaGqBP9\nvniLkMEmgUk4KxkRJUq5DZhn+/FDNGg/nWAbJXhoG8FaCvnxFoMsSeSBUk/a7Zog\ntIhCf7rFN/+s6Jub4z0x03YfZ6+a9wyYQnzKSCY2SjMUAcvV0+EM6tuvMdZdMqu8\nvNSDznh9AgMBAAECggEAAXBtuxOs5f0Rv2t3xKm4KMRxOlaahXFIsWdQFgPgOQkX\nA4ZOD00QULFoqkN/aXWMNboMI0azltKK+s0BKAIWc6VOSjyT2IhyJCuW3YaQKasp\nztK/IwKJ/p/taoyYIpj5YiTDvCqV8qmbPf/4fRw65ImGC+/iTR4UXw+6xntP3tK2\nGmaYDnwPVX7g023sCyWG0PRQBMfxE+BFQwQSNmFmbBZ1pjFg18ec7tk+Mx8pYHRK\nng/8ejsrT4vuTMKL7oe/Q72g5JS2njfYYNUTcI+LRiv/RA3cWXuTfWUEwc/oDqSc\nl//mWlB6yXg9uVxReV4yUNiNLUs4pOWCh28GM52IgQKBgQDYgWVL3AmE442kpAt6\nX32CckTGa2Veud0wAcfpzyvqzhEfVpLI2uJ+dcbYkV2AW17enFc3ltIcCw5tLL3f\nQpmflmO5ULBIAqFrVoVJsj4d8d7o4pnyEq8fRW9JTMPixFouuE+FeRKihZhMBq9g\n3od/88Oqdt3bN4DSK5lCU7e/ZQKBgQDOEy/LywqlkbE8QOcdZYFFOQ5e0Yd+yNxu\nzHMRdzLXZMaFTnfDFb0ZhGbpFS/ClvG6a7scU0wLQiZifyyKXon8WwfJk1DWUEy0\n4ayOzRNMVWjgqismul1ItARo8YLjvVkcToLY+gWeqOKjgjq4ujRr7EcIVPE7xllU\nvZr7z28/OQKBgAfefB4Lu1TXKHjJdZlXCyrImHNVx/Nvcfiit+9plkEMiFbJQMCI\nJB9QjI+miO13ZLVWnVzp4G0ggb+6FpScyRSh1LIRmrajUdai6GlLTzKrbdytD8da\non7SeT8CyUPeuyBjlpBVXDYIAQcSXyF4NRiTdZMmit3C4K3C4+kjPdR5AoGBAIHI\nP5+/PfNMMCzcSzGOTb2E03IPz5+fbIQzKnzjbxeMFiK6al5ogHFjm1RLzYpledOI\nKY0LQKcOgBIkOa7jH0/ZHKxspMp0Q/re7cf5i5/VYnmrcgWv9TPme6iEAYTgKRDU\nuT9hJsznW+TSDZ1tV7poUcwDgvG8V2IxDzxrRYqxAoGBAJ7CNwJSjb7EQgyZ1lYC\nvWrUHV1NlX/0ZCY3R2su4yj4YD7VzrNM7I7zSl00qyfQ1SwEuiTng5xxNlqQw5di\nZkorXZQxjtAyXse966ulXruPOH7eEhYf2UZyZ8LJz2O4fEwN+gDn+MQiW+ISO7PM\ncdav37HCM+hoLvzpmXfdF9ou\n-----END PRIVATE KEY-----\n",
"client_email": "[email protected]",
"client_id": "105810230224217721483",
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
"token_uri": "https://oauth2.googleapis.com/token",
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/firebase-adminsdk-kjrcz%40laravel-config.iam.gserviceaccount.com"
}

0 comments on commit 0988334

Please sign in to comment.