feat(System): configuration option firebase to store data #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenthanhtuanIT
force-pushed
the
feat/System/config-firebase
branch
from
7f3c0fb to
0f1404e
Compare
nguyenthanhtuanIT
changed the title
src/Services/FirebaseService.php
Outdated
| */ | ||
| public function getDataByCode($code) | ||
| { | ||
| $reference = $this->getRetrievingData(GGConfig::REFERENCE); |
There was a problem hiding this comment.
REFERENCE => SYSTEM_REFERENCE
src/Models/GGConfig.php
Outdated
| if (empty($configInfo)) { | ||
| $firebaseService->addData(GGConfig::REFERENCE, $attributes); | ||
| } else { | ||
| if (getKeyByCode($code)) |
There was a problem hiding this comment.
elseif ($key = getKeyByCode($code))
$firebaseService->setData(GGConfig::REFERENCE . '/' . $key, $attributes);
src/Services/FirebaseService.php
Outdated
| * @param string $reference | ||
| * @return object | ||
| */ | ||
| public function getRetrievingData($reference = null) |
There was a problem hiding this comment.
getRetrievingData => retrieveData or getData
src/Resources/views/config.blade.php
Outdated
| $config = env('STORE_DB', 'database') == 'database' | ||
| ? getConfigByCode($field['code']) | ||
| : app('GGPHP\Config\Services\FirebaseService')->getDataByCode($field['code']); | ||
| $value = $config ? $config['value'] : null; |
There was a problem hiding this comment.
$value = $config ? $config['value'] : null; => $value = $config['value'] ?? null
- composer require kreait/laravel-firebase - php artisan route:cache see #34
nguyenthanhtuanIT
force-pushed
the
feat/System/config-firebase
branch
from
0f1404e to
ae0e7be
Compare
HuynhHungManh
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer require kreait/laravel-firebase
php artisan route:cache
see #34