Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue when using Memcached as the Play! cache implementation #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tazmaniax
Copy link
Contributor

Greenscript was adding a value to Memcached before the value had been populated. Change was to wait until the value was populated and then add to Memcached.

  1. Add protected onWriterClose() method to BufferResource that is called when the writer is closed. Defaults to doing nothing.
  2. Updated GreenScriptPlugin.bufferLocator_.newBuffer(List
    resourceNames, String extension) to anonymously extend the
    BufferResource instance and define the onClose() method to do
    the Cache.set(...)
  3. Removed unnecessary @OverRide annotations

when the writer is closed. Defaults to doing nothing.
2. Updated GreenScriptPlugin.bufferLocator_.newBuffer(List
resourceNames, String extension) to anonymously extend the
BufferResource instance and define the onClose() method to do
the Cache.set(...)
3. Removed unnecessary @OverRide annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant