Fix for crash on AndroidX #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventbus is crashing when my app is running on a device with an API level below 26 and using the AndroidX libraries. The problem is that a NoClassDefFoundError is being thrown for the TextClassifier that's a parameter in the AppCompatTextView#setTextClassifier() method. The reflection code you use doesn't filter for API level, unfortunately. A quick fix is to add "androidx." to the system classes in the moveToSuperClass() method. You should probably do this for performance reasons in any case.
The EventBus API will crash if it runs into a method that takes a parameter that the app doesn't recognise. Android gets around this using the @TargetAPI annotation, but this requires a minimum API level of 15. The easiest way to fix this is reverse the order of checking the number of parameters a method takes and whether the Subscribe annotation is present. This means the getParameterTypes() call is deferred, and if a system library incorporates something not available on a given API level, it won't find an unknown type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventbus is crashing when my app is running on a device with an API level below 26 and using the AndroidX libraries.
The problem is that a NoClassDefFoundError is being thrown for the TextClassifier that's a parameter in the AppCompatTextView#setTextClassifier() method. The reflection code you use doesn't filter for API level, unfortunately.
A quick fix is to add "androidx." to the system classes in the moveToSuperClass() method. You should probably do this for performance reasons in any case.