-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added seven neumes to gregall #1587
base: develop
Are you sure you want to change the base?
Conversation
I know our nabc coverage is severely lacking in the gregorio-test, but could you make some tests for these new glyphs so that we at least get started on testing the nabc glyphs? |
If there are no objections this week, I'm going to accept and merge this PR despite the lack of tests. |
Please don't. I am not happy with the results and I beg @jakubjelinek to have a look at it first. |
Sorry for not getting into this earlier. StartChar: space |
And the fontforge I have crashes on the added characters. The main reason I'm still on the old fontforge is because they've changed the UI for creating splines and it creates different style looking characters from the old one. |
The mess with the rest of the file is clearly caused by the version discrepancy, of which I was unaware. I could try and install the old fontforge along the new (what version is yours?) and copy-paste the characters from one to the other. Do you think it would be viable? |
From the *.tex files, seems it is just 4 new glyphs and then 3 glyphs done by removing some part, I'll just try to do those myself, shouldn't take that long. |
Regarding the neume naming, the neume in https://www.e-codices.unifr.ch/en/csg/0391/204 certainly doesn't look like toS (the crooked torculus extra slow form), but either just to or maybe toS1. |
So, I have |
to!cl> : https://www.e-codices.unifr.ch/en/csg/0391/213 R/ Peto domine, "hUius" (first line) with respect to to!cl vs toS!cl, well, I am not a professional semiologist, but I tend to distinguish between cases where the articulation between the first two notes of a torculus is very round (the first note and the articulation forming, together, half of a circle, as in the usual 'to' and 'toS1'), and cases where the first note is a straight dash with an inflexion point, followed by a more angled articulation (like in gregall's pe>1). I think the glyphs in https://www.e-codices.unifr.ch/en/csg/0391/204 , R/ Emitte domine, which you saw, belong to the second kind, where the first two notes really look like the beginning of pe>1 (or toS for that matter). |
Added toS!cl-lsi8 from Hartker, and derived toS!cl- and toS!cl from it.
Added ql-ppt1sut2su1 from Hartker.
Derived to!cl> from to!cl->.
Please review the following facts: