Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to end after a number of occurrances or on a date #117

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

rflorence
Copy link

Maps to the count or until IceCube::Rule attributes.
screen shot 2017-08-01 at 4 03 15 pm
Similar to #61 and #96

@Frank004
Copy link

@rflorence are you running this on rails 5?

@rflorence
Copy link
Author

@Frank004 no I'm only using this with Rails 4.2. Maybe it could be merged with #115 and work on Rails 5.

@rflorence
Copy link
Author

The Rails 5 fix is included in this PR now.

@justinsoong
Copy link

👍 keen!!!

@justinsoong
Copy link

@rflorence maintainers seem to have left, are you using your own forked version?

@rflorence
Copy link
Author

Yes, I am using my fork in a production app.

@justinsoong
Copy link

@rflorence thanks! i think there have been a few more Rails 5 Fixes, which very likely will be addressed in some recent the commits, maybe if the conflicts get resolved, someone will green light it? I think this feature is a great one would love it to have it work on > rails 5

JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 5, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 6, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 6, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 6, 2024
JimmyToor added a commit to JimmyToor/recurring_select that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants