fix: repoint Trivy to use ECR mirror

[ramirezj]

Summary by CodeRabbit

• New Features

  • Introduced a new environment variable trivy_sarif to enhance the reporting of security scan results.

• Bug Fixes

  • Improved the accuracy of SARIF output uploads from the Trivy scan to the code-scanning dashboard.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the GitHub Actions workflow in .github/workflows/speculative-plan.yaml. It adds a new environment variable, trivy_sarif, to the trivy job, which is used to direct the output of the Trivy scan. This variable is referenced in the Run with SARIF Output step and the Report via GitHub CodeQL step for uploading the SARIF output. The structure of the terraform-cloud-speculative-run job remains unchanged, and the overall permissions for the jobs are retained.

Changes

File	Change Summary
.github/workflows/speculative-plan.yaml	Added environment variable trivy_sarif to trivy job; updated steps to use this variable for SARIF output.

Possibly related PRs

• fix: repoint Trivy to use ECR mirror #273: This PR modifies the same GitHub Actions workflow file and also adds environment variables to the trivy job, including the trivy_sarif variable, which is directly related to the changes made in the main PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Terraform Cloud Plan Output

Plan: 0 to add, 0 to change, 0 to destroy.
Terraform Cloud Plan

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.github/workflows/speculative-plan.yaml (1)

Line range hint 103-104: Consider version pinning for ECR repositories

Whilst using AWS Public ECR mirrors is a good practice for reliability, consider pinning specific versions or digests for the Trivy databases to ensure consistent and reproducible scans. This prevents potential issues from unexpected database updates.

Example:

-TRIVY_DB_REPOSITORY: "public.ecr.aws/aquasecurity/trivy-db"
+TRIVY_DB_REPOSITORY: "public.ecr.aws/aquasecurity/trivy-db:2"
-TRIVY_JAVA_DB_REPOSITORY: "public.ecr.aws/aquasecurity/trivy-java-db"
+TRIVY_JAVA_DB_REPOSITORY: "public.ecr.aws/aquasecurity/trivy-java-db:2"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 73a0993 and 724d099.

📒 Files selected for processing (1)

• .github/workflows/speculative-plan.yaml (1 hunks)

🔇 Additional comments (1)

.github/workflows/speculative-plan.yaml (1)

82-82: Well-structured environment variable addition

Good practice using an environment variable to maintain the SARIF filename in a single location. This makes it more maintainable and reduces the risk of mismatched filenames.