* Improved write_greta_install_log() and read_greta_install_log()
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use `tools::R_user_dir()` to always write to a file location. `read_greta_install_log()` will open one found from an environment variable or go to the default location. (greta-dev#703)
maelle
reviewed
Aug 20, 2024
R/install_greta_deps.R
Outdated
| #' not specified the `GRETA_INSTALLATION_LOG` environmental variable, the | ||
| #' installation notes will indicate how to use [write_greta_install_log()]. | ||
| #' `greta_set_install_logfile('path/to/logfile.html')`. By default it uses | ||
| #' `tools::R_user_dir("greta")`. To see installation notes or errors, after |
There was a problem hiding this comment.
tools::R_user_dir("greta") is a folder so what's the file path?
R/install_greta_deps.R
Outdated
| greta_default_logfile <- function(){ | ||
| greta_user_dir <- get_pkg_user_dir() | ||
| default_greta_logfile_path <- glue::glue( | ||
| "{greta_user_dir}/greta-installation-logfile.html" |
There was a problem hiding this comment.
why not file.path(greta_user_dir, "greta-installation-logfile.html")? I once read one should not paste to create a path but I can't remember why (the slash difference on OS? something else?)
There was a problem hiding this comment.
Good point! I'm in a habit using glue for everything.
…cifying not just a directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
tools::R_user_dir()to always write to a file location.read_greta_install_log()will open one found from an environment variable or go to the default location. (#703)Thanks @maelle for this excellent suggestion!