-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set of improvements/fixes in Gridap.Adaptivity module #886
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #886 +/- ##
==========================================
- Coverage 88.53% 87.89% -0.65%
==========================================
Files 172 173 +1
Lines 20107 20398 +291
==========================================
+ Hits 17802 17928 +126
- Misses 2305 2470 +165
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@amartinhuertas Have a look at the concept version, experiment and check if it's indeed what you need. If so, I'll implement a generic version for any degree pair |
Note that I can also produce very easily the inverse map, i.e for each coarse edge a vector containing the properly ordered dof ids of the fine edges below it. |
The CI errors are weird.... I have not touched that part of the code, and all tests pass locally.... Could this be a mistake in the master branch? |
…rule-subface-glue
…rule-subface-glue Conflicts: src/Adaptivity/AdaptedDiscreteModels.jl src/Adaptivity/EdgeBasedRefinement.jl
…rule-subface-glue
This allows for CartesianDiscreteModels to be created from arbitrary (grid,topo,label) tuples.
Things part of this PR:
get_face_subface_ldof_to_cell_ldof
, a glue between coarse and fine lagrangian dofs forRedRefinementRules
.get_d_to_face_to_parent_face
get_d_to_face_to_child_faces