Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of improvements/fixes in Gridap.Adaptivity module #886

Merged
merged 30 commits into from
Aug 3, 2023

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Mar 15, 2023

Things part of this PR:

  • New: Implement get_face_subface_ldof_to_cell_ldof, a glue between coarse and fine lagrangian dofs for RedRefinementRules.
  • Bugfix: Correct labeling of refined models.
  • Bring fixes/changes from GridapP4est.jl#p4est-migration-exploring-non-conformity
  • Implement generic version of get_d_to_face_to_parent_face
  • Implement generic version of get_d_to_face_to_child_faces
  • Bugfix: Allow domain limits to be floats in cartesian refinement routines.

@JordiManyer JordiManyer self-assigned this Mar 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #886 (39e0175) into master (6ce09af) will decrease coverage by 0.65%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   88.53%   87.89%   -0.65%     
==========================================
  Files         172      173       +1     
  Lines       20107    20398     +291     
==========================================
+ Hits        17802    17928     +126     
- Misses       2305     2470     +165     
Files Changed Coverage Δ
src/Adaptivity/OldToNewFields.jl 0.00% <0.00%> (ø)
src/ReferenceFEs/ExtrusionPolytopes.jl 90.19% <ø> (ø)
src/Adaptivity/AdaptedTriangulations.jl 77.36% <28.57%> (-5.40%) ⬇️
src/Adaptivity/RefinementRules.jl 61.64% <37.50%> (-33.97%) ⬇️
src/Adaptivity/EdgeBasedRefinement.jl 89.17% <60.37%> (-4.67%) ⬇️
src/Adaptivity/AdaptivityGlues.jl 76.25% <65.33%> (-12.81%) ⬇️
src/Adaptivity/AdaptedDiscreteModels.jl 80.20% <68.75%> (-3.52%) ⬇️
src/Geometry/CartesianDiscreteModels.jl 99.61% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JordiManyer
Copy link
Member Author

@amartinhuertas Have a look at the concept version, experiment and check if it's indeed what you need. If so, I'll implement a generic version for any degree pair (p,2*p).
I leave a sketch of the toy model I'm using for the concept implementation:
DOF_glue.pdf

@JordiManyer
Copy link
Member Author

Note that I can also produce very easily the inverse map, i.e for each coarse edge a vector containing the properly ordered dof ids of the fine edges below it.

@JordiManyer
Copy link
Member Author

The CI errors are weird.... I have not touched that part of the code, and all tests pass locally.... Could this be a mistake in the master branch?

amartinhuertas added a commit to gridap/GridapP4est.jl that referenced this pull request Apr 11, 2023
@JordiManyer
Copy link
Member Author

JordiManyer commented Apr 12, 2023

For future reference, here are the refinement rules for HEX:

  • White -> Child comes from vertex
  • Blue -> Child comes from edge
  • Red -> Child comes from face
  • Green -> Child comes from cell

image

image

image

image

@amartinhuertas amartinhuertas changed the title Coarse-to-child face glue for RefinementRules Set of improvements/fixes in Gridap.Adaptivity module Aug 3, 2023
amartinhuertas added a commit to gridap/GridapP4est.jl that referenced this pull request Aug 3, 2023
@amartinhuertas amartinhuertas marked this pull request as ready for review August 3, 2023 09:11
@amartinhuertas amartinhuertas merged commit add5f00 into master Aug 3, 2023
7 checks passed
@JordiManyer JordiManyer deleted the refinement-rule-subface-glue branch August 3, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Face labelling tags of an UnstructuredDiscreteModel changed after refining
3 participants