Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enable set profile #10

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

derjaeckel
Copy link

Enable to set a pdf profile optionally
Ensure a type-safe way to set an optional Profile (that meany, that only values from getAllowedValues are allowed)
Update Documentation

@peschee
Copy link
Contributor

peschee commented Mar 31, 2017

@derjaeckel Although I totally see this as a valid feature, this project is merely a wrapper around the original and unchanged PHP wrapper provided by @yeslogic

I have been in contact with the team members there and proposed to them to create a separate Github repository for each wrapper in order to make it easier for people to contribute changes like these. I haven't heard back.

I suggest you add the feature to the original repository at https://github.com/yeslogic/prince-tools/tree/master/wrappers/php5 As soon as the changes to the library are incorporated, we can create a new major release reflecting those changes.

@derjaeckel
Copy link
Author

@peschee Ah, i understand. Thank you for your response so far. Let's keep waiting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants