Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xtb/docking test #1173

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

foxtran
Copy link
Contributor

@foxtran foxtran commented Feb 1, 2025

During careful running of xtb/docking test via CMake I have found several divisions by zero and improperly closing of files. This patch resolves such issues

@Albkat
Copy link
Member

Albkat commented Feb 2, 2025

Hi, thanks for all the fixes. I now have time again for support and will merge all your fixes after reviewing them.

@foxtran
Copy link
Contributor Author

foxtran commented Feb 10, 2025

@Albkat, ping :-)

@foxtran
Copy link
Contributor Author

foxtran commented Feb 10, 2025

Hohoho. Funny :)
4 tests are started to fail...

@Albkat
Copy link
Member

Albkat commented Feb 10, 2025

Hohoho. Funny :) 4 tests are started to fail...

But those failures could be related to this PR, since they are all iff related :)

@foxtran
Copy link
Contributor Author

foxtran commented Feb 10, 2025

But those failures could be related to this PR, since they are all iff related :)

Before rebasing on current master they were green :-)

@Albkat
Copy link
Member

Albkat commented Feb 10, 2025

But those failures could be related to this PR, since they are all iff related :)

Before rebasing on current master they were green :-)

I see, then it is indeed strange.
@cplett, could you look into this?

@foxtran
Copy link
Contributor Author

foxtran commented Feb 10, 2025

Ok. I've reproduced it at my computer.

@foxtran
Copy link
Contributor Author

foxtran commented Feb 10, 2025

Fixed now. I made too early condition for cycling to next iteration. :-(

…ex type transformations

Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Signed-off-by: Igor S. Gerasimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants