Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isotope hessian #1176

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

marcelmbn
Copy link
Member

Fixes issue #1143

Problem

  • Isotope masses were overridden by physical values.

Fix

  • shift initialization of atomic masses directly to line directly after allocation of the array atmass (see init_split).

@marcelmbn marcelmbn added bug Something isn't working easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project labels Feb 5, 2025
@marcelmbn marcelmbn self-assigned this Feb 5, 2025
@marcelmbn marcelmbn linked an issue Feb 5, 2025 that may be closed by this pull request
@marcelmbn
Copy link
Member Author

marcelmbn commented Feb 5, 2025

General question, @Albkat @awvwgk: We don't have any validation tests that access the CLI of xtb, i.e. tests that actually execute the xtb binary with a call like the following, right?

xtb --hess struc.xyz

In this way, we could also test this feature. Up to now, this can easily be broken again by some PR that works on main.F90 and doesn't know about such features and doesn't check them manually.

@marcelmbn
Copy link
Member Author

@demonic-daisy @MtoLStoN Maybe you can look quickly into this to check if the sandwich potential thing could be affected by this (but I don't think so).

@marvinfriede marvinfriede merged commit 7ef22f6 into grimme-lab:main Feb 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isotope information ignored for vibrational/thermodynamic quantities
2 participants