Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement invitation by phone number #154

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

dvkolesnikov
Copy link
Contributor

  • Show number of available invites on the Profile screen
  • Invite a user by their phone number without sharing your contact list

@dvkolesnikov
Copy link
Contributor Author

dvkolesnikov commented Feb 24, 2021

Have you tried sending invites without sharing contacts?
originally had a similar implementation #144 but some users (according to them) are banned for this

I have successfully invited only 2 persons but it was less than hour ago. I've seen your PR #144 but I didn't know that sharing contacts is necessary. Probably, it's needed to be tested more thoroughly before merging.

@zm21
Copy link

zm21 commented Feb 25, 2021

Have you tried sending invites without sharing contacts?
originally had a similar implementation #144 but some users (according to them) are banned for this

Have you tried sending invites without sharing contacts?
originally had a similar implementation #144 but some users (according to them) are banned for this

I have successfully invited only 2 persons but it was less than hour ago. I've seen your PR #144 but I didn't know that sharing contacts is necessary. Probably, it's needed to be tested more thoroughly before merging.

I used your version 1.0.9 and for some reason I can't invite anyone. I receive notifications that I have 0 invitations. Why if I didn't invite anyone?

@dvkolesnikov
Copy link
Contributor Author

I used your version 1.0.9 and for some reason I can't invite anyone. I receive notifications that I have 0 invitations. Why if I didn't invite anyone?

I don't know for sure what is the rules of granting invitations to the user on the server side. Do I understand right that server returns num_invites = 0 in the /me response for your user?

@zm21
Copy link

zm21 commented Feb 25, 2021

I used your version 1.0.9 and for some reason I can't invite anyone. I receive notifications that I have 0 invitations. Why if I didn't invite anyone?

I don't know for sure what is the rules of granting invitations to the user on the server side. Do I understand right that server returns num_invites = 0 in the /me response for your user?

Yes

@dvkolesnikov
Copy link
Contributor Author

dvkolesnikov commented Feb 25, 2021

I don't know for sure what is the rules of granting invitations to the user on the server side. Do I understand right that server returns num_invites = 0 in the /me response for your user?

Yes

I've just got 3 new invitations in my profile. It looks like they grant them periodically (daily?). So, probably, you should just wait for some time.

@badmanbh
Copy link

where i can download 1.0.9 with this feature? I only find 1.0.8 apk (latest release)

@dvkolesnikov
Copy link
Contributor Author

where i can download 1.0.9 with this feature? I only find 1.0.8 apk (latest release)

You can build it by yourself ifyou have Android Studio installed or you should wait until the PR is reviewed and merged

@grishka could you, please, review the PR? It doesn't conflict with #144 but allows the user to invite others without sending the contact list to the server.

@grishka grishka merged commit 7f7879b into grishka:master Feb 26, 2021
@dvkolesnikov dvkolesnikov deleted the feature/invite_by_phone_num branch February 26, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants