Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom command lines as "PARALLEL_TESTS_EXECUTABLE" #972

Conversation

deivid-rodriguez
Copy link
Contributor

This used to work until 7fd7518. I think it was an oversight so this change adds the proper shellspliting so that it keeps working.

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • Update Readme.md when cli options are changed

Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, makes sense
... only downside would be anyone trying to have an executable with spaces in it, but then they can escape that 🤷

@grosser grosser merged commit e96f60c into grosser:master Sep 10, 2024
13 checks passed
@grosser
Copy link
Owner

grosser commented Sep 10, 2024

4.7.2

@deivid-rodriguez deivid-rodriguez deleted the allow-passing-command-lines-as-custom-executable branch September 10, 2024 16:55
@deivid-rodriguez
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants