Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_message_callback: use Fn instead of FnMut #295

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

surban
Copy link
Contributor

@surban surban commented Jul 8, 2024

The callback may be called simultaneously from different threads. Thus it must use a non-mutable function.

Fixes #289

The callback may be called simultaenously from different threads.
Thus it must use a non-mutable function.
Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@grovesNL grovesNL merged commit 601e4b1 into grovesNL:main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raw_debug_message_callback might be called from multiple threads at once
2 participants