Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness: Make some private & internal classes sealed where possible #2559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Henr1k80
Copy link

Should in theory also be faster, as some virtual method table lookups can be avoided.
I haven't tested if it introduces any performance regressions due to runtime black magic inner workings.
My laptop cannot produce repeatable results due to throttling & background services.
I hope you have a benchmark setup to test it.

There are some whitespace changes due to:
trim_trailing_whitespace = true
insert_final_newline = true
in .editorconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant