Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds, pickfirst: Enable additional addresses in xDS, set new pick_first as default #8126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Feb 26, 2025

Tested

  • Ran all internal tests (global TAP) with the flags turned on, verified none of the failures were related.
  • PSM interop Dual Stack tests passing since 14th Feb.

RELEASE NOTES:

  • pickfirst: The new pick first LB policy is made the default. The new LB policy implements the Happy Eyeballs algorithm (see A61) to connect to multiple addresses concurrently. To disable the new policy set the environment variable GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST to false (case insensitive).
  • xds: LB policies will receive additional addresses for endpoints which are specified in the additional_addresses field in the Endpoint message. The additional addresses will be present in the ResolverState.Endpoints passed to UpdateClientConnState method of the balancers. To diable this feature, set the environment variable GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS to false (case insensitive).

@arjan-bal arjan-bal added this to the 1.71 Release milestone Feb 26, 2025
@arjan-bal arjan-bal added the Type: Feature New features or improvements in behavior label Feb 26, 2025
@arjan-bal arjan-bal force-pushed the enable-dualstack-flags branch from 3fb6f32 to aa373c9 Compare February 26, 2025 06:49
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (dbf92b4) to head (aa373c9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8126      +/-   ##
==========================================
+ Coverage   82.18%   82.26%   +0.08%     
==========================================
  Files         387      387              
  Lines       38947    38947              
==========================================
+ Hits        32007    32041      +34     
+ Misses       5613     5586      -27     
+ Partials     1327     1320       -7     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from dfawley February 26, 2025 06:55
@arjan-bal arjan-bal changed the title xds, pickfirst: Enable additional addresses in xDS and new pick_first as default xds, pickfirst: Enable additional addresses in xDS, set new pick_first as default Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants