Skip to content

Commit

Permalink
Revert "Revert "Temporarily disable protoc-plugin in CI"" (#1451)
Browse files Browse the repository at this point in the history
* Revert "Revert "Temporarily disable protoc-plugin in CI (#1447)" (#1448)"

This reverts commit e6909cd.

* Update run_basic_tests.sh
  • Loading branch information
sampajano authored Jun 25, 2024
1 parent 132ed2c commit 20790fc
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion scripts/run_basic_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ docker-compose down
echo -e "\n[Running] Basic test #3 - Testing everything buids"
if [[ "$MASTER" == "1" ]]; then
# Build all for continuous_integration
docker-compose build
# docker-compose build

# Temporary fix `protoc-plugin` build failure (introduced in
# https://github.com/grpc/grpc-web/pull/1445) by building
# everything but it.
# TODO: Revert to building all targets.
docker-compose build prereqs echo-server node-server node-interop-server envoy grpcwebproxy commonjs-client closure-client ts-client binary-client interop-client jsunit-test
else
# Only build a subset of docker images for presubmit runs
docker-compose build commonjs-client closure-client ts-client
Expand Down

0 comments on commit 20790fc

Please sign in to comment.