-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-plugin
image is currently broken
#1449
Comments
I'm afraid I can't spend a huge amount of time digging into all ways there are to build the generator at the moment in this repo. (There's also a |
@benjaminp No worries! Appreciate your effort in trying to help anyways!!
It's ok.. I think we have to move forward anyways.. I've temporarily disabled protoc_plugin in CI so BUILD is green now. But we have to fix it for a new release to be made :) |
Note to myself: we are currently pinning the protobuf submodule version: grpc-web/scripts/init_submodules.sh Line 19 in 20790fc
This is for 2 reasons:
Ideally, (1) should be tackled first — by moving to https://github.com/protocolbuffers/protobuf-javascript, since protobuf has removed JS from its repo. And then (2) — ensuring Makefile work as before. |
FYI - Once we have this working we can make a test binary for #715 |
See: #1446 (comment)
The
protoc_plugin
image is broken since #1445@benjaminp FYI :)
UPDATE: Temporarily disabled in #1451
The text was updated successfully, but these errors were encountered: