Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase steam load timeout #442

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Increase steam load timeout #442

merged 4 commits into from
Jul 15, 2024

Conversation

gruhn
Copy link
Owner

@gruhn gruhn commented Jul 15, 2024

see #298

The ESLint setup is broken somehow and since linting is a pre-commit hook
it blocks the committing process. Thus, removing the setup entirely for
now. To be fixed later if deemed necessary.
@Asko-Dev reports that the `SteamLoadTimeoutError` seems to be thrown
"randomly" on iOS 17.5.1. That suggests that there is a race condition
with the timeout. Let's try to double the timeout (3s -> 6s) and see if
that helps.

See: #298
Copy link

github-actions bot commented Jul 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-15 20:37 UTC

@gruhn gruhn merged commit a5dbaa2 into master Jul 15, 2024
1 check passed
@gruhn gruhn deleted the increase-steam-load-timeout branch July 15, 2024 20:37
Copy link

🎉 This PR is included in version 5.5.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant