Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skip_templating feature (#167) #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rwittrick
Copy link

Description

Fixes #167.

Adds the top level skip_templating config to boilerplate.yaml. In terms of config, it works the same as skip_files. skip_templating will copy any file matched in the config without rendering or templating it. skip_files takes precedence if a path is listed in both.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added skip_templating feature.

@denis256
Copy link
Member

        --- FAIL: TestExamplesAsRemoteTemplate/group/skip-templating (5.73s)
        --- PASS: TestExamples/skip-not-path-multiple/skip-not-path-multiple-missing-key-error (0.00s)
    --- FAIL: TestExamples/skip-templating (0.02s)
        --- FAIL: TestExamples/skip-templating/skip-templating-missing-key-invalid (0.01s)
        --- FAIL: TestExamples/skip-templating/skip-templating-missing-key-zero (0.01s)
        --- FAIL: TestExamples/skip-templating/skip-templating-missing-key-error (0.01s)

@rwittrick
Copy link
Author

I updated the typo in the tests with a new commit.

I'll look further into running the tests locally. They fail as the first suite use a hard coded reference to the gruntwork repo URL with a parameterized gitref, but for an outside committer the branch isn't available in that repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore templating some file or directories
2 participants