Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Non-AWS dependency updates #54

Merged
merged 9 commits into from
Oct 10, 2024
Merged

chore(deps): Non-AWS dependency updates #54

merged 9 commits into from
Oct 10, 2024

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

About this PR

Updates:

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version numbers

The following files still refer to the old version numbers.
You might want to review and update them manually.

build.sbt
⚙ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "ch.epfl.scala", artifactId = "sbt-version-policy" },
  { groupId = "com.github.sbt", artifactId = "sbt-release" },
  { groupId = "com.twitter", artifactId = "scrooge-core" },
  { groupId = "com.twitter", artifactId = "scrooge-sbt-plugin" },
  { groupId = "io.circe", artifactId = "circe-core" },
  { groupId = "io.circe", artifactId = "circe-generic" },
  { groupId = "io.circe", artifactId = "circe-parser" },
  { groupId = "org.apache.thrift", artifactId = "libthrift" },
  { groupId = "org.gnieh", artifactId = "diffson-circe" },
  { groupId = "org.scala-lang", artifactId = "scala-library" },
  { groupId = "org.scala-sbt", artifactId = "sbt" },
  { groupId = "org.scalatest", artifactId = "scalatest" },
  { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-version-policy" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.github.sbt", artifactId = "sbt-release" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.twitter", artifactId = "scrooge-core" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.twitter", artifactId = "scrooge-sbt-plugin" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "io.circe", artifactId = "circe-core" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "io.circe", artifactId = "circe-generic" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "io.circe", artifactId = "circe-parser" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.apache.thrift", artifactId = "libthrift" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.gnieh", artifactId = "diffson-circe" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" }
  }
]
labels: dependencies, sbt-plugin-update, library-update, test-library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, early-semver-minor, semver-spec-minor, early-semver-major, old-version-remains, commit-count:n:11

@gu-scala-steward-public-repos gu-scala-steward-public-repos bot requested a review from a team as a code owner September 12, 2024 15:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Unit Test Results

18 tests  ±0   18 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c4d23f4. ± Comparison against base commit e8f235d.

♻️ This comment has been updated with latest results.

@emdash-ie
Update tests to avoid DecodingFailure equality
c4d23f4 
The error messages have changed, so these tests need updating (Maybe the
tests shouldnʼt depend on the error message? Not sure), but also it
seems the definition of equality for DecodingFailure has changed: I
couldnʼt get the failures constructed in the tests to compare equal to
the ones from circe. So Iʼve changed these tests to explicitly compare
the message and history.
@emdash-ie
Copy link
Contributor

I’ve removed the thrift and scrooge updates from this PR, as there’s some version that we can’t yet update to and I can’t remember offhand what that is.

emdash-ie
emdash-ie approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this since the tests pass

@emdash-ie emdash-ie merged commit fb0afd7 into main Oct 10, 2024
2 checks passed
@emdash-ie emdash-ie deleted the update/non_aws branch October 10, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdash-ie emdash-ie emdash-ie approved these changes

Assignees
No one assigned
Labels
commit-count:n:11 dependencies early-semver-major early-semver-minor early-semver-patch library-update old-version-remains sbt-plugin-update semver-spec-minor semver-spec-patch test-library-update version-scheme:early-semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emdash-ie