Update typescript version in test projects #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divs-B
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
I have tested locally, 6 tests that were failing before, are now passing all fine.
Good to go ahead, thanks @georgeblahblah for fixing 👍
|
Would like to have @rtyley to double check this. |
ok! Feel free to merge this without me when you're ready if you need it soon! |
rtyley
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
As this PR only changes stuff in the tests, it should be very low risk to merge and will fix our tests in this repo, yay!
When a new release goes out, it would be good to test it in a consumer project like https://github.com/guardian/content-api-models, but there should be very low risk, due to no implementation code being changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
package.json. This fixes tests run withsbt test