Replace esbuild-jest
with @swc/jest
#1014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun fact, esbuild-jest cannot compile/transform tests that have the characters
ock(
anywhere in the code! This makes it very hard to mock anything withjest.mock()
! See aelbore/esbuild-jest#57What does this change?
Replace
esbuild-jest
with@swc/jest
Why?
Fun nightmare JS ecosystem fact of the day:
esbuild-jest
cannot compile any tests that include the charactersock(
in their code! See this issue . This makes it pretty hard to mock anything usingjest.mock()
😅There are workarounds but nothing very pleasant.
Required for #989
How has it been verified?
Ran
npm run test
in the workspace root. Also rannpm -w cdk run test -- -u
to verify snapshots still work.