Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction fee covered label to new one-time checkout #6719

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

andrewHEguardian
Copy link
Contributor

What are you doing in this PR?

Add the transaction-fee-covered label to the acquisition data when the checkbox is ticket.

Trello Card

Why are you doing this?

The label was missed when implementing the feature on the new checkout, which means it's harder (or impossible) to figure out how many people checked the box and bought a one-off contribution.

How to test

Buy a one-off contribution and see the label in the datalake

Screenshots

image

...referrerAcquisitionData,
labels: [
...(referrerAcquisitionData.labels ?? []),
'one-time-checkout',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can get rid of this now it's the only one time checkout left?

Copy link
Contributor

Size Change: +88 B (0%)

Total Size: 2.37 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.5 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.2 kB -2 B (0%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 254 kB +48 B (+0.02%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.6 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.5 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 164 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.1 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.2 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.1 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 21.7 kB 0 B
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/311.js 40.1 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/426.js 36.5 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/754.js 9.92 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 14.3 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 10 kB +42 B (+0.42%)
./public/compiled-assets/webpack/ThankYou.js 1.08 kB 0 B

compressed-size-action

Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewHEguardian andrewHEguardian merged commit a349cfd into main Jan 23, 2025
19 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/transaction-fee-covered-label branch January 23, 2025 09:14
@prout-bot
Copy link

Seen on PROD (merged by @andrewHEguardian 11 minutes and 3 seconds ago)

Sentry Release: support-client-side, support

Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants