-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction fee covered label to new one-time checkout #6719
Conversation
...referrerAcquisitionData, | ||
labels: [ | ||
...(referrerAcquisitionData.labels ?? []), | ||
'one-time-checkout', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can get rid of this now it's the only one time checkout left?
Size Change: +88 B (0%) Total Size: 2.37 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Seen on PROD (merged by @andrewHEguardian 11 minutes and 3 seconds ago)
Sentry Release: support-client-side, support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
What are you doing in this PR?
Add the
transaction-fee-covered
label to the acquisition data when the checkbox is ticket.Trello Card
Why are you doing this?
The label was missed when implementing the feature on the new checkout, which means it's harder (or impossible) to figure out how many people checked the box and bought a one-off contribution.
How to test
Buy a one-off contribution and see the label in the datalake
Screenshots