This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
Master #753
Open
Master #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the process even more foolproof.
This should solve cases where OTR does not init when a user creates a username with uppercase letters init (See ticket for more detailed info). All in all, normalizing usernames before persistence/account creation is a very good thing to do.
fixes #4461 (and others) related to invalid username/jids
- still looking into a way to show pending/subscribe notices here
also re-impl subscription dialog prompts properly
These two languages must be included twice (iw/he and id/in) For a full discussion of why, see: https://gitlab.com/fdroid/fdroidclient/issues/139 https://stackoverflow.com/questions/5074769/cyanogenmod-translate-a-project/8470980#8470980 https://stackoverflow.com/questions/8393771/android-not-using-finding-my-hebrew-localization
…ification methods for parameters in SMP. The methods 'checkGroupElem' and 'checkExpon' are basic methods that are used to verify parameters of SMP. These methods used bad boundary conditions when checking values. As a result, some valid values were flagged as invalid parameters while others were wrongly accepted. A number of tests are included that check values next to the boundaries to ensure that verification is executed correctly. As part of looking into these errors, I have verified the other methods of SM.java. Apart from 'checkGroupElem' and 'checkExpon' all methods match their counterparts in java-otr and libotr. (AFAICT)
fix SMP error and hebrew/indonesian translations
GitHub #672 Allowing setting negative XMPP priority
WindowManager E android.view.WindowLeaked: Activity org.awesomeapp.messenger.RouterActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{41bea2d8 V.E..... R......D 0,0-1140,192} that was originally
added here
E at android.view.ViewRootImpl.<init>(ViewRootImpl.java:346)
E at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
E at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
E at android.app.Dialog.show(Dialog.java:286)
E at org.awesomeapp.messenger.RouterActivity$1.onPreExecute(RouterActivity.java:493)
E at android.os.AsyncTask.executeOnExecutor(AsyncTask.java:587)
E at android.os.AsyncTask.execute(AsyncTask.java:535)
E at org.awesomeapp.messenger.RouterActivity.completeShutdown(RouterActivity.java:481)
E at org.awesomeapp.messenger.RouterActivity.openEncryptedStores(RouterActivity.java:550)
E at org.awesomeapp.messenger.RouterActivity.onCacheWordOpened(RouterActivity.java:431)
E at info.guardianproject.cacheword.CacheWordHandler.checkCacheWordState(CacheWordHandler.java:409)
E at info.guardianproject.cacheword.CacheWordHandler.access$100(CacheWordHandler.java:27)
E at info.guardianproject.cacheword.CacheWordHandler$1.onReceive(CacheWordHandler.java:440)
E at android.support.v4.content.LocalBroadcastManager.executePendingBroadcasts(LocalBroadcastManager.java:297)
E at android.support.v4.content.LocalBroadcastManager.access$000(LocalBroadcastManager.java:46)
E at android.support.v4.content.LocalBroadcastManager$1.handleMessage(LocalBroadcastManager.java:116)
E at android.os.Handler.dispatchMessage(Handler.java:102)
E at android.os.Looper.loop(Looper.java:136)
E at android.app.ActivityThread.main(ActivityThread.java:5001)
E at java.lang.reflect.Method.invokeNative(Native Method)
E at java.lang.reflect.Method.invoke(Method.java:515)
E at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
E at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
E at dalvik.system.NativeStart.main(Native Method)
dalvikvm I Jit: resizing JitTable from 4096 to 8192
AndroidRuntime D Shutting down VM
dalvikvm W threadid=1: thread exiting with uncaught exception (group=0x4160bba8)
HockeyApp D Writing unhandled exception to: /data/data/org.awesomeapp.messenger.debug/files/161c58f9-1887-4501-bcbf-6e95728eabe6.stacktrace
AndroidRuntime E FATAL EXCEPTION: main
E Process: org.awesomeapp.messenger.debug, PID: 19550
E java.lang.IllegalArgumentException: View=com.android.internal.policy.impl.PhoneWindow$DecorView{41bea2d8 V.E..... R......D 0,0-1140,192} not attached to window manager
E at android.view.WindowManagerGlobal.findViewLocked(WindowManagerGlobal.java:370)
E at android.view.WindowManagerGlobal.removeView(WindowManagerGlobal.java:299)
E at android.view.WindowManagerImpl.removeViewImmediate(WindowManagerImpl.java:84)
E at android.app.Dialog.dismissDialog(Dialog.java:329)
E at android.app.Dialog.dismiss(Dialog.java:312)
E at org.awesomeapp.messenger.RouterActivity$1.onPostExecute(RouterActivity.java:533)
E at org.awesomeapp.messenger.RouterActivity$1.onPostExecute(RouterActivity.java:481)
E at android.os.AsyncTask.finish(AsyncTask.java:632)
E at android.os.AsyncTask.access$600(AsyncTask.java:177)
E at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645)
E at android.os.Handler.dispatchMessage(Handler.java:102)
E at android.os.Looper.loop(Looper.java:136)
E at android.app.ActivityThread.main(ActivityThread.java:5001)
E at java.lang.reflect.Method.invokeNative(Native Method)
E at java.lang.reflect.Method.invoke(Method.java:515)
E at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
E at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
E at dalvik.system.NativeStart.main(Native Method)
Process I Sending signal. PID: 19550 SIG: 9
This makes the app fully exit, and removes it from the Recent Apps listing with the goal of hiding whatever the user was currently watching, and/or searching for. PanicKit provides a common framework for creating "panic button" apps that can trigger actions in "panic responder" apps. In this case, the response is to lock the app, if it has been configured to do so https://dev.guardianproject.info/projects/panic/wiki
add panic response
This just switches the if/else logic a bit so that all failures show the Toast. It also purges the unused doKeyStoreImport and exportKeyStore
Right now, if an app sends an .ofcaes file to chatsecure, it is just ignored, but will launch ChatSecure, which is confusing.
getExternalDbFilePath() will return null, and new File(null) crashes:
java.lang.RuntimeException: Unable to start activity ComponentInfo{info.guardianproject.otr.app.im/info.guardianproject.otr.app.im.app.WelcomeActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1651)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1667)
at android.app.ActivityThread.access$1500(ActivityThread.java:117)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:935)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:130)
at android.app.ActivityThread.main(ActivityThread.java:3687)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:507)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:625)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at java.io.File.fixSlashes(File.java:205)
at java.io.File.init(File.java:189)
at java.io.File.<init>(File.java:139)
at info.guardianproject.otr.app.im.app.WelcomeActivity.checkMediaStoreFile(WelcomeActivity.java:526)
at info.guardianproject.otr.app.im.app.WelcomeActivity.onCreate(WelcomeActivity.java:104)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1615)
... 11 more
It seems that not all devices can handle it:
java.lang.RuntimeException: Unable to start activity ComponentInfo{info.guardianproject.otr.app.im/info.guardianproject.otr.app.im.app.WelcomeActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2351)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2403)
at android.app.ActivityThread.access$600(ActivityThread.java:165)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1373)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:194)
at android.app.ActivityThread.main(ActivityThread.java:5416)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:525)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:833)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:600)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at info.guardianproject.otr.app.im.app.ThemeableActivity.setBackgroundImage(ThemeableActivity.java:79)
at info.guardianproject.otr.app.im.app.ThemeableActivity.onCreate(ThemeableActivity.java:31)
at info.guardianproject.otr.app.im.app.WelcomeActivity.onCreate(WelcomeActivity.java:91)
at android.app.Activity.performCreate(Activity.java:5276)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1152)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2315)
... 11 more
It was detecting the file and getting the QR reader up, but it was not getting the data from the QR and then doing the actual import.
get keysync working again
Added missing translation strings for "Add new account" pages.
Added missing translation strings
Add retired notice to README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.